Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value-keyword-case in scss list #4019

Merged

Conversation

3 participants
@alexander-schranz
Copy link
Contributor

commented Apr 11, 2019

The problem is that parsed.toString() converts // with /* I avoid this converting not calling the fixer in a expected case.

Which issue, if any, is this issue related to?

Fixes #3847

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@alexander-schranz alexander-schranz changed the title WIP: Fix value-keyword-case in scss list Fix value-keyword-case in scss list Apr 11, 2019

@hudochenkov
Copy link
Member

left a comment

LGTM! Thanks!

@jeddy3

jeddy3 approved these changes Apr 13, 2019

Copy link
Member

left a comment

@alexander-schranz Thanks for your contribution!

@jeddy3 jeddy3 merged commit 9b76cec into stylelint:master Apr 13, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 96.379%
Details
@jeddy3

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

  • Fixed: value-keyword-case autofix for single-line comments within maps (#4019).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.