Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RangeError in indentation regression #4572

Merged
merged 2 commits into from Feb 5, 2020
Merged

Fix RangeError in indentation regression #4572

merged 2 commits into from Feb 5, 2020

Conversation

XhmikosR
Copy link
Member

Fixes #4551.

@jeddy3 Feel free to add more tests

@jeddy3
Copy link
Member

jeddy3 commented Jan 28, 2020

Feel free to add more tests

I adapted your test. I moved it into the previous testRule instance as we only create a new one if the configuration changes. I used common-tags to nicely indent your test within the code. We use this approach in some of our more recent rules.

jeddy3
jeddy3 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fix LGTM, thanks!

@jeddy3 jeddy3 changed the title indentation: fix RangeError regression Fix RangeError in indentation regression Jan 28, 2020
@XhmikosR XhmikosR mentioned this pull request Feb 1, 2020
Closed
21 tasks
@jeddy3 jeddy3 merged commit 7524601 into master Feb 5, 2020
@jeddy3 jeddy3 deleted the master-xmr-indent-2 branch February 5, 2020 20:35
@jeddy3
Copy link
Member

jeddy3 commented Feb 5, 2020

  • Fixed: indentation RangeError regression (#4572).

@jeddy3 jeddy3 mentioned this pull request Feb 5, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix RangeError in indentation
4 participants
@XhmikosR @jeddy3 @hudochenkov @alexander-akait