Fix false positives for inlines styles in declaration-empty-line-before #4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
changed the title
m-allanson
approved these changes
May 12, 2020
|
Changelog:
In hindsight, I should have merged all these fix pull requests before the preset one. I fixed up the files in 5775e00, rather than inconvenience the authors with a rebase in their forks. @malsf21 Thanks again for the pull request. Apologies for the delay in getting it merged. Some big chunks of work were happening in the background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a PR that fixes a false-positive on the rule
declaration-empty-line-before(#4658): in particular, when it's used for inline styles. I did this by adding aisFirstNodeOfRootcheck to the declaration walker.Closes #4658.
I added the tests recommended by @jeddy3 in the issue discussion, and it looks like the pass a local run of
npm test.If there are any other changes needed for the PR, please let me know!