Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reportDisables secondary option #4897

Merged
merged 4 commits into from Aug 19, 2020
Merged

Add a reportDisables secondary option #4897

merged 4 commits into from Aug 19, 2020

Conversation

@nex3
Copy link
Contributor

@nex3 nex3 commented Aug 13, 2020

This allows config authors to specify that certain rules may not be disabled by authors.

nex3 added 3 commits Aug 11, 2020
This allows us to re-use this structure for representing errors
relating to disabled that aren't specifically related to the disable
being unused.
This allows config authors to specify that certain rules may not be
disabled by authors.

Closes #4875
@vankop
vankop approved these changes Aug 15, 2020
Copy link
Member

@vankop vankop left a comment

👍

Please add a description to PR, this is useful for CHANGELOG

lib/reportDisables.js Outdated Show resolved Hide resolved
types/stylelint/index.d.ts Show resolved Hide resolved
Copy link
Contributor Author

@nex3 nex3 left a comment

Please add a description to PR, this is useful for CHANGELOG

Done.

lib/reportDisables.js Outdated Show resolved Hide resolved
types/stylelint/index.d.ts Show resolved Hide resolved
@jathak
jathak approved these changes Aug 18, 2020
@nex3
Copy link
Contributor Author

@nex3 nex3 commented Aug 18, 2020

Is this good to merge? Should I add a CHANGELOG entry in the PR itself?

@vankop vankop merged commit 858dcd5 into master Aug 19, 2020
11 checks passed
11 checks passed
CodeQL
Details
CodeQL
Details
Lint on Node.js 12 and ubuntu-latest
Details
Test on Node.js 10 and ubuntu-latest
Details
Test on Node.js 10 and windows-latest
Details
Test on Node.js 10 and macos-latest
Details
Test on Node.js 12 and windows-latest
Details
Test on Node.js 12 and macos-latest
Details
Coverage on Node.js 12 and ubuntu-latest
Details
CodeQL No new alerts
Details
coverage/coveralls Coverage increased (+0.02%) to 96.575%
Details
@vankop vankop deleted the disable-disallows branch Aug 19, 2020
@vankop
Copy link
Member

@vankop vankop commented Aug 19, 2020

yep, need to add a changelog entry. Core team should handle it =)

m-allanson added a commit that referenced this pull request Sep 3, 2020
* master: (34 commits)
  Update CHANGELOG.md
  Fix double-slash disable comments when followed by another comment (#4913)
  Update CHANGELOG.md (#4916)
  13.7.0
  Prepare 13.7.0
  Prepare changelog
  Update dependencies
  Update CHANGELOG.md
  Deprecate *-blacklist/*-requirelist/*-whitelist (#4892)
  Fix some path / glob problems (#4867)
  Update CHANGELOG.md
  Add a reportDescriptionlessDisables flag (#4907)
  Fix CHANGELOG.md format via Prettier (#4910)
  Fix callbacks in tests (#4903)
  Update CHANGELOG.md
  Fix false positives for trailing combinator in selector-combinator-space-after (#4878)
  Add coc-stylelint (#4901)
  Update CHANGELOG.md
  Add support for *.cjs config files (#4905)
  Add a reportDisables secondary option (#4897)
  ...
@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Sep 13, 2020

yep, need to add a changelog entry. Core team should handle it =)

It's a clunky process, and I've created an issue (#4934) to discuss how we can improve managing the changelog and releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.