Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for css-in-js in color-no-hex #5186

Merged
merged 2 commits into from Mar 8, 2021

Conversation

@Dru89
Copy link
Contributor

@Dru89 Dru89 commented Mar 6, 2021

style-search returns false positives when used with css-in-js object notation. This change continues with the discussion in #4826 and moves another test towards using postcss-value-parser.

Dru89 added 2 commits Mar 6, 2021
`style-search` returns false positives when used with `css-in-js` object
notation. This change continues with the discussion in stylelint#4826 and moves
another test away from using `style-search`.
@jeddy3 jeddy3 changed the title Use postcss-value-parser for color-no-hex rule Fix false positives for css-in-js in color-no-hex Mar 6, 2021
jeddy3
jeddy3 approved these changes Mar 6, 2021
Copy link
Member

@jeddy3 jeddy3 left a comment

@Dru89 Fantastic, thanks.

LGTM from the get-go.

Loading

Copy link
Member

@ybiquitous ybiquitous left a comment

LGTM, thanks! 😄

Loading

@jeddy3 jeddy3 merged commit caaf2e5 into stylelint:master Mar 8, 2021
13 checks passed
Loading
@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Mar 8, 2021

  • Fixed: color-no-hex false positives for CSS-in-JS objection notation (#5186).

@Dru89 you're welcome to clone the stylelint repo directly, rather than work from a fork.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants