Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for level 4 math functions in length-zero-no-unit #5203

Conversation

@tomyo
Copy link
Contributor

@tomyo tomyo commented Mar 19, 2021

Closes #5199

Is there anything in the PR that needs further explanation?

First commit is simply small styling alignment, not part of the issue, but small enough to simply include here I guess.

Copy link
Member

@ybiquitous ybiquitous left a comment

LGTM 👍

Loading

lib/rules/length-zero-no-unit/__tests__/index.js Outdated Show resolved Hide resolved
Loading
@tomyo tomyo force-pushed the ignore-level-4-math-functions-in-length-zero-no-unit branch from a143e5e to 01a4e81 Mar 23, 2021
jeddy3
jeddy3 approved these changes Mar 26, 2021
Copy link
Member

@jeddy3 jeddy3 left a comment

Thanks!

Loading

@jeddy3 jeddy3 merged commit ee7515a into stylelint:master Mar 26, 2021
13 checks passed
Loading
@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Mar 26, 2021

Changelog entry added:

  • Fixed: length-zero-no-unit false positives for level 4 math functions (#5203).

Loading

@tomyo tomyo deleted the ignore-level-4-math-functions-in-length-zero-no-unit branch Mar 26, 2021
lucaswerkmeister added a commit to wmde/wikit that referenced this issue Jun 15, 2021
This includes a fix for false positives of the length-zero-no-unit rule
in min() or max() (see stylelint/stylelint#5203 [1]).

[1]: stylelint/stylelint#5203
lucaswerkmeister added a commit to wmde/wikit that referenced this issue Jun 17, 2021
This includes a fix for false positives of the length-zero-no-unit rule
in min() or max() (see stylelint/stylelint#5203 [1]).

[1]: stylelint/stylelint#5203
sai-san added a commit to wmde/wikit that referenced this issue Jun 21, 2021
* Update stylelint to 13.13.1

This includes a fix for false positives of the length-zero-no-unit rule
in min() or max() (see stylelint/stylelint#5203 [1]).

[1]: stylelint/stylelint#5203

* Check for overflow in Popover

We try to avoid overflow with several adjustments – see the comments of
the avoidOverflow…() methods for details. Adjustments that change the
`position` prop can be disabled with the new `forcePosition` prop. Each
adjustment is tried in order, only if the previous adjustments weren’t
enough to avoid the overflow, and the adjustments are cumulative.

The whole procedure to avoid overflow is repeated each time the popover
is shown, as well as on window resize and when the position prop
changes. However, we don’t listen to changes in the slot contents,
because there seems to be no straightforward way to do that, and
implementing it probably wouldn’t be worth the effort (it would mainly
be useful for the storybook, I assume).

The “making edges flush” adjustment uses the CSS min() function, which
is not available in IE11; however, that should only mean that the
adjustment is effectively disabled in IE11 (the value should fall back
to the non-flush rule, some calc(...)), without breaking anything else.

Bug: T274261

Co-authored-by: SaiSan <sarai.sanchez@wikimedia.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants