Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for dollar variables in no-invalid-position-at-import-rule #5264

Merged
merged 1 commit into from May 1, 2021

Conversation

@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 27, 2021

Which issue, if any, is this issue related to?

Closes #5263

Is there anything in the PR that needs further explanation?

Switches the logic around so that the invalidPosition flag is set when a standard syntax rule or at-rule (that isn't charset or another import) is encountered.

It maps neatly onto the spec:

Any @import rules must precede all other valid at-rules and style rules in a style sheet (ignoring @charset), or else the @import rule is invalid.

@jeddy3 jeddy3 changed the title Fix false positives for dollar variables Fix false positives for dollar variables in no-invalid-position-at-import-rule Apr 27, 2021
Copy link
Member

@ybiquitous ybiquitous left a comment

Looks good! 👍🏼

@jeddy3 jeddy3 mentioned this pull request Apr 30, 2021
6 of 6 tasks complete
@jeddy3 jeddy3 force-pushed the issue-5263 branch from 302e636 to e82d8cc Apr 30, 2021
Copy link
Member

@mattxwang mattxwang left a comment

LGTM!

@jeddy3 jeddy3 merged commit 2e90b96 into master May 1, 2021
16 checks passed
16 checks passed
@github-actions
Analyze
Details
@github-actions
Lint on Node.js 14 and ubuntu-latest
Details
@github-actions
Test on Node.js 10 and ubuntu-latest
Details
@github-actions
Test on Node.js 10 and windows-latest
Details
@github-actions
Test on Node.js 10 and macos-latest
Details
@github-actions
Test on Node.js 12 and ubuntu-latest
Details
@github-actions
Test on Node.js 12 and windows-latest
Details
@github-actions
Test on Node.js 12 and macos-latest
Details
@github-actions
Test on Node.js 14 and windows-latest
Details
@github-actions
Test on Node.js 14 and macos-latest
Details
@github-actions
Test on Node.js 16 and ubuntu-latest
Details
@github-actions
Test on Node.js 16 and windows-latest
Details
@github-actions
Test on Node.js 16 and macos-latest
Details
@github-actions
Coverage on Node.js 14 and ubuntu-latest
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
coverage/coveralls Coverage increased (+0.0003%) to 96.687%
Details
@jeddy3 jeddy3 deleted the issue-5263 branch May 1, 2021
@jeddy3
Copy link
Member Author

@jeddy3 jeddy3 commented May 1, 2021

  • Fixed: no-invalid-position-at-import-rule false positives for dollar variables (#5264).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants