Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lib/__tests__/standalone-fix.test.js #5270

Merged
merged 1 commit into from Apr 30, 2021

Conversation

@ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 30, 2021

  • Remove the del package that will be needless.
  • Use async/await syntax for readability. (#4881)
  • Fix CSS code indent for consistency.

Which issue, if any, is this issue related to?

A part of #4881

Is there anything in the PR that needs further explanation?

del is still in package-lock.json as a sub-dependency of np:

$ npm ls del
stylelint@13.13.0 /Users/masafumi.koba/git/stylelint/stylelint
└─┬ np@7.4.0
  └── del@6.0.0
@ybiquitous ybiquitous marked this pull request as ready for review Apr 30, 2021
- Remove the `del` package that will be needless.
- Use async/await syntax for readability. (#4881)
- Fix CSS code indent for consistency.
@jeddy3 jeddy3 force-pushed the refactor-standalone-fix.test.js branch from 70d7486 to a9d476b Apr 30, 2021
@jeddy3
jeddy3 approved these changes Apr 30, 2021
Copy link
Member

@jeddy3 jeddy3 left a comment

Much better, thanks!

@jeddy3 jeddy3 merged commit c52f9ae into master Apr 30, 2021
16 checks passed
16 checks passed
@github-actions
Analyze
Details
@github-actions
Lint on Node.js 14 and ubuntu-latest
Details
@github-actions
Test on Node.js 10 and ubuntu-latest
Details
@github-actions
Test on Node.js 10 and windows-latest
Details
@github-actions
Test on Node.js 10 and macos-latest
Details
@github-actions
Test on Node.js 12 and ubuntu-latest
Details
@github-actions
Test on Node.js 12 and windows-latest
Details
@github-actions
Test on Node.js 12 and macos-latest
Details
@github-actions
Test on Node.js 14 and windows-latest
Details
@github-actions
Test on Node.js 14 and macos-latest
Details
@github-actions
Test on Node.js 16 and ubuntu-latest
Details
@github-actions
Test on Node.js 16 and windows-latest
Details
@github-actions
Test on Node.js 16 and macos-latest
Details
@github-actions
Coverage on Node.js 14 and ubuntu-latest
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
coverage/coveralls Coverage remained the same at 96.687%
Details
@jeddy3 jeddy3 deleted the refactor-standalone-fix.test.js branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants