Fix false negatives for invalid options in *-list #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
force-pushed
the
refactor-to-use-validateObjectWithArrayProps
branch
from
d3c9933
to
f292d22
Compare
ybiquitous
force-pushed
the
refactor-to-use-validateObjectWithArrayProps
branch
from
f292d22
to
1c00330
Compare
ybiquitous
reviewed
Feb 20, 2022
| /** | ||
| * Check whether the variable is an object and all its properties are arrays of string values: | ||
| * Check whether the variable is an object and all its properties are arrays of values | ||
| * that satisfy the specified validator(s): |
There was a problem hiding this comment.
[note] Fixed the inaccurate comment.
|
|
||
| return Object.values(value).every((array) => { | ||
| if (!Array.isArray(array)) { | ||
| module.exports = function validateObjectWithArrayProps(validator) { |
There was a problem hiding this comment.
[note] Giving the function name changed indentation.
jeddy3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
None.
This change aims to tighten rule validations having object options like
at-rule-property-required-list.For example, when the following configuration is given,
{ "rules": { "at-rule-property-required-list": { "font-family": [1] } } }a validation error should be expected,
but actually no errors.