Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column position for declaration-property-value-*-list #5926

Merged
merged 1 commit into from Feb 21, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Feb 21, 2022

Which issue, if any, is this issue related to?

None. (but I found this problem when looking into #5725)

Is there anything in the PR that needs further explanation?

This change aims to fix a column position for the following rules:

/* Before */
a { position: fixed }
/*  ↑
 *  The column index is located at the declaration.
 */

/* After */
a { position: fixed }
/*            ↑
 *            The column index is located at the declaration value.
 */

This positioning is the same as declaration-property-unit-allowed-list.

See also the demo.

@ybiquitous ybiquitous marked this pull request as ready for review Feb 21, 2022
jeddy3
jeddy3 approved these changes Feb 21, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

This positioning is the same as declaration-property-unit-allowed-list.

Consistent is good.

LGTM, thanks!

@ybiquitous ybiquitous merged commit 012870f into main Feb 21, 2022
14 checks passed
@ybiquitous ybiquitous deleted the fix-position-for-declaration-property-value-list branch Feb 21, 2022
@ybiquitous
Copy link
Member Author

@ybiquitous ybiquitous commented Feb 21, 2022

Updated changelog:

  • Fixed: column position for declaration-property-value-*-list (#5926).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants