Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives/negatives in selector-pseudo-class-no-unknown #5956

Merged
merged 2 commits into from Mar 9, 2022

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Mar 8, 2022

Which issue, if any, is this issue related to?

Closes #5173

Is there anything in the PR that needs further explanation?

check the commit message for details
prompted by #5205 (comment)

 - `user-valid`
 - `-moz-placeholder`
 - `-moz-ui-invalid`
 - `-moz-ui-valid`
 - `-ms-input-placeholder`

add missing pseudo elements:
 - `-moz-focus-outer`
 - `-moz-placeholder`
 - `-webkit-input-placeholder`

fixes stylelint#5173

https://developer.mozilla.org/en-US/docs/web/css/:user-valid
https://bugzilla.mozilla.org/show_bug.cgi?id=457801
https://bugzilla.mozilla.org/show_bug.cgi?id=737786
lib/reference/keywordSets.js Outdated Show resolved Hide resolved
Copy link
Member

@jeddy3 jeddy3 left a comment

Thanks!

Let's remove user-error too.

lib/reference/keywordSets.js Outdated Show resolved Hide resolved
@jeddy3 jeddy3 changed the title Remove :contains() (#5173), Add missing pseudo elements/classes (non exhaustive) Fix false positives/negatives in selector-pseudo-class-no-unknown Mar 8, 2022
@Mouvedia
Copy link
Contributor Author

@Mouvedia Mouvedia commented Mar 8, 2022

Let's remove user-error too.

done

jeddy3
jeddy3 approved these changes Mar 8, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Thank you! LGTM.

Copy link
Member

@ybiquitous ybiquitous left a comment

Looks good! 👍🏼

lib/reference/keywordSets.js Show resolved Hide resolved
@jeddy3 jeddy3 merged commit 60dd0c3 into stylelint:main Mar 9, 2022
14 checks passed
@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Mar 9, 2022

Changelog entry added:

  • Fixed: selector-pseudo-class-no-unknown false positives and negatives (#5956).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants