Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vendor prefixes in property-(dis)allowed-list #6025

Merged

Conversation

carlosjeurissen
Copy link
Contributor

@carlosjeurissen carlosjeurissen commented Apr 19, 2022

Which issue, if any, is this issue related to?

Closes #5981

Is there anything in the PR that needs further explanation?

The parameter types for matchesStringOrRegExp had to be fixed. It didn't include Array.

@jeddy3 jeddy3 added the pr: needs tests label Apr 19, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

@carlosjeurissen Thanks for the pull request. Can you add a test for this change, please?

@jeddy3 jeddy3 changed the title Property disallowed list prefixes Add support for vendor prefixes in property-*-list Apr 19, 2022
Copy link
Member

@ybiquitous ybiquitous left a comment

@carlosjeurissen Thank you so much for the first contribution!

In addition, can you address the following?

@ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 19, 2022

Ah, I've overlapped with @jeddy3 😅

@ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 19, 2022

@jeddy3 Do you think it's necessary to remove the unprefixed word from the rule doc?

`array|string|regex`: `["array", "of", "unprefixed", /properties/, "regex"]|"property"|"/regex/"|/regex/`

@carlosjeurissen
Copy link
Contributor Author

@carlosjeurissen carlosjeurissen commented Apr 19, 2022

Addressed the property-allowed-list, README.md and the tests. Thanks for the suggestions!

Copy link
Member

@ybiquitous ybiquitous left a comment

Great. LGTM 👍🏼

@jeddy3 jeddy3 removed the pr: needs tests label Apr 20, 2022
jeddy3
jeddy3 approved these changes Apr 20, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

LGTM, thank you!

@jeddy3 jeddy3 merged commit 65b5652 into stylelint:main Apr 20, 2022
14 checks passed
@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 20, 2022

Changelog entry added:

  • Added: property-*-list support for vendor prefixes (#6025).

@carlosjeurissen carlosjeurissen changed the title Add support for vendor prefixes in property-*-list Add support for vendor prefixes in property-(dis)allowed-list Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants