Fix false positives for interpolation in keyframes-name-pattern #6265
Conversation
| @@ -38,6 +39,10 @@ const rule = (primary) => { | |||
| return; | |||
| } | |||
|
|
|||
| if (!isStandardSyntaxKeyframesName(value)) { | |||
There was a problem hiding this comment.
Let's move this to before the first conditionally as we normally check that things are standard before any other operation.
|
|
||
| describe('isStandardSyntaxKeyframesName', () => { | ||
| it('standard name', () => { | ||
| expect(isStandardSyntaxKeyframesName('@keyframes slidein {}')).toBeTruthy(); |
There was a problem hiding this comment.
| expect(isStandardSyntaxKeyframesName('@keyframes slidein {}')).toBeTruthy(); | |
| expect(isStandardSyntaxKeyframesName('slidein')).toBeTruthy(); |
As the util is checking the keyframes-name, and not the whole @keyframe.
We'll need to update the other tests too.
| */ | ||
|
|
||
| module.exports = function (keyframesName) { | ||
| // SCSS or Less interpolation |
There was a problem hiding this comment.
| // SCSS or Less interpolation |
We can lose the comment. (The hasInterpolation util checks for more than just Less or Sass interpolation).
jeddy3
changed the title
|
@jeddy3 Thank you for your review! |
|
@ybiquitous Thank you! I've made the updates. |
|
|
||
| describe('isStandardSyntaxKeyframesName', () => { | ||
| it('standard name', () => { | ||
| expect(isStandardSyntaxKeyframesName('slidein {}')).toBe(true); |
There was a problem hiding this comment.
| expect(isStandardSyntaxKeyframesName('slidein {}')).toBe(true); | |
| expect(isStandardSyntaxKeyframesName('slidein')).toBe(true); |
We're only testing the name, not the block. We'll need to remove the block from the other tests too.
|
@jeddy3 So so sorry for missing this. All the blocks should be removed now. |
|
Changelog entry added:
|
Closes #5997
No, it's self-explanatory.