From 7696bfb366f04a91d50535991806f61122ed194c Mon Sep 17 00:00:00 2001 From: Romain Menke Date: Fri, 10 Feb 2023 18:49:15 +0100 Subject: [PATCH 1/4] Fix `declaration-property-value-no-unknown` false positives for `env()` --- .../declaration-property-value-no-unknown/__tests__/index.js | 3 +++ lib/rules/declaration-property-value-no-unknown/index.js | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rules/declaration-property-value-no-unknown/__tests__/index.js b/lib/rules/declaration-property-value-no-unknown/__tests__/index.js index 62505cd012..99748a5b8d 100644 --- a/lib/rules/declaration-property-value-no-unknown/__tests__/index.js +++ b/lib/rules/declaration-property-value-no-unknown/__tests__/index.js @@ -19,6 +19,9 @@ testRule({ { code: 'a { top: var(--foo); }', }, + { + code: 'a { top: env(titlebar-area-height); }', + }, { code: 'a { foo: 1px; }', }, diff --git a/lib/rules/declaration-property-value-no-unknown/index.js b/lib/rules/declaration-property-value-no-unknown/index.js index 0ae887c33c..7bc90de660 100644 --- a/lib/rules/declaration-property-value-no-unknown/index.js +++ b/lib/rules/declaration-property-value-no-unknown/index.js @@ -130,6 +130,7 @@ const rule = (primary, secondaryOptions) => { * some math functions like `clamp()` via `fork()`. In the future, it may be unnecessary. * * @see https://github.com/stylelint/stylelint/pull/6511#issuecomment-1412921062 + * @see https://github.com/stylelint/stylelint/issues/6635#issuecomment-1425787649 * * @param {import('css-tree').CssNode} cssTreeNode * @returns {boolean} @@ -138,7 +139,7 @@ function containsUnsupportedMathFunction(cssTreeNode) { return Boolean( find( cssTreeNode, - (node) => node.type === 'Function' && ['clamp', 'min', 'max'].includes(node.name), + (node) => node.type === 'Function' && ['clamp', 'min', 'max', 'env'].includes(node.name), ), ); } From bd0884f42e662b96f256402f81c328341ded99d0 Mon Sep 17 00:00:00 2001 From: Romain Menke <11521496+romainmenke@users.noreply.github.com> Date: Fri, 10 Feb 2023 18:50:40 +0100 Subject: [PATCH 2/4] Create serious-moose-applaud.md --- .changeset/serious-moose-applaud.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/serious-moose-applaud.md diff --git a/.changeset/serious-moose-applaud.md b/.changeset/serious-moose-applaud.md new file mode 100644 index 0000000000..e4693e2b1b --- /dev/null +++ b/.changeset/serious-moose-applaud.md @@ -0,0 +1,5 @@ +--- +"stylelint": patch +--- + +Fix `declaration-property-value-no-unknown` false positives for `env()` From e48702c3fd8a92cc074b2d7b1bd76549f9e015b6 Mon Sep 17 00:00:00 2001 From: Romain Menke Date: Fri, 10 Feb 2023 19:00:38 +0100 Subject: [PATCH 3/4] feedback --- .changeset/serious-moose-applaud.md | 2 +- lib/rules/declaration-property-value-no-unknown/index.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/serious-moose-applaud.md b/.changeset/serious-moose-applaud.md index e4693e2b1b..cecd027229 100644 --- a/.changeset/serious-moose-applaud.md +++ b/.changeset/serious-moose-applaud.md @@ -2,4 +2,4 @@ "stylelint": patch --- -Fix `declaration-property-value-no-unknown` false positives for `env()` +Fixed `declaration-property-value-no-unknown` false positives for `env()` diff --git a/lib/rules/declaration-property-value-no-unknown/index.js b/lib/rules/declaration-property-value-no-unknown/index.js index 7bc90de660..6c095e1e8c 100644 --- a/lib/rules/declaration-property-value-no-unknown/index.js +++ b/lib/rules/declaration-property-value-no-unknown/index.js @@ -89,7 +89,7 @@ const rule = (primary, secondaryOptions) => { try { cssTreeValueNode = parse(value, { context: 'value' }); - if (containsUnsupportedMathFunction(cssTreeValueNode)) return; + if (containsUnsupportedFunction(cssTreeValueNode)) return; } catch (e) { result.warn(`Cannot parse property value "${value}"`, { node: decl, @@ -135,7 +135,7 @@ const rule = (primary, secondaryOptions) => { * @param {import('css-tree').CssNode} cssTreeNode * @returns {boolean} */ -function containsUnsupportedMathFunction(cssTreeNode) { +function containsUnsupportedFunction(cssTreeNode) { return Boolean( find( cssTreeNode, From aee9f105e390917e38f863011766da3b76b397a9 Mon Sep 17 00:00:00 2001 From: Romain Menke Date: Fri, 10 Feb 2023 19:02:29 +0100 Subject: [PATCH 4/4] feedback Co-authored-by: Richard Hallows --- .changeset/serious-moose-applaud.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/serious-moose-applaud.md b/.changeset/serious-moose-applaud.md index cecd027229..030f233343 100644 --- a/.changeset/serious-moose-applaud.md +++ b/.changeset/serious-moose-applaud.md @@ -2,4 +2,4 @@ "stylelint": patch --- -Fixed `declaration-property-value-no-unknown` false positives for `env()` +Fixed: `declaration-property-value-no-unknown` false positives for `env()`