From 0197df8f08b1b17632649d4878a57125a5f79b4c Mon Sep 17 00:00:00 2001 From: Yasir761 <74600745+Yasir761@users.noreply.github.com> Date: Mon, 24 Apr 2023 23:45:41 +0530 Subject: [PATCH 1/3] Updated pseudo class --- lib/reference/selectors.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/reference/selectors.js b/lib/reference/selectors.js index 69ff5892ff..5acfb77182 100644 --- a/lib/reference/selectors.js +++ b/lib/reference/selectors.js @@ -277,6 +277,7 @@ const pseudoClasses = uniteSets( 'last-child', 'last-of-type', 'link', + 'modal', 'only-child', 'only-of-type', 'optional', From 582b04f117532af8452be9c0b05f45ff30c8a62d Mon Sep 17 00:00:00 2001 From: Yasir761 <74600745+Yasir761@users.noreply.github.com> Date: Wed, 26 Apr 2023 23:11:12 +0530 Subject: [PATCH 2/3] Add test case as suggested --- .changeset/many-mugs-camp.md | 5 +++++ .../__tests__/index.js | 11 +++++++++++ 2 files changed, 16 insertions(+) create mode 100644 .changeset/many-mugs-camp.md diff --git a/.changeset/many-mugs-camp.md b/.changeset/many-mugs-camp.md new file mode 100644 index 0000000000..13695c5c62 --- /dev/null +++ b/.changeset/many-mugs-camp.md @@ -0,0 +1,5 @@ +--- +"stylelint": minor +--- + +Fixed selector-pseudo-class-no-unknown false positive for :modal diff --git a/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js b/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js index 1874a48225..ac228c535e 100644 --- a/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js +++ b/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js @@ -28,6 +28,9 @@ testRule({ { code: 'a::before { }', }, + { + code: 'a:modal { }', + }, { code: "input:not([type='submit']) { }", }, @@ -127,6 +130,14 @@ testRule({ endLine: 1, endColumn: 10, }, + { + code: 'a:modal { }', + message: messages.rejected(':modal'), + line: 1, + column: 2, + endLine: 1, + endColumn: 10, + }, { code: 'a:Unknown { }', message: messages.rejected(':Unknown'), From 3e601d84222ca815ba5ad61033e1e1fcdad11fe1 Mon Sep 17 00:00:00 2001 From: Yasir761 <74600745+Yasir761@users.noreply.github.com> Date: Sat, 29 Apr 2023 21:46:42 +0530 Subject: [PATCH 3/3] make changes in test code --- .changeset/many-mugs-camp.md | 2 +- .../__tests__/index.js | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.changeset/many-mugs-camp.md b/.changeset/many-mugs-camp.md index 13695c5c62..61e350203d 100644 --- a/.changeset/many-mugs-camp.md +++ b/.changeset/many-mugs-camp.md @@ -2,4 +2,4 @@ "stylelint": minor --- -Fixed selector-pseudo-class-no-unknown false positive for :modal +Fixed: `selector-pseudo-class-no-unknown` false positive for `:modal` diff --git a/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js b/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js index ac228c535e..54dc317bae 100644 --- a/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js +++ b/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js @@ -29,7 +29,7 @@ testRule({ code: 'a::before { }', }, { - code: 'a:modal { }', + code: ':modal { }', }, { code: "input:not([type='submit']) { }", @@ -130,14 +130,6 @@ testRule({ endLine: 1, endColumn: 10, }, - { - code: 'a:modal { }', - message: messages.rejected(':modal'), - line: 1, - column: 2, - endLine: 1, - endColumn: 10, - }, { code: 'a:Unknown { }', message: messages.rejected(':Unknown'),