bunch of stuff #192
bunch of stuff #192
Conversation
|
I've rebased commits from #94 but there is still one failing test that i'm not sure how to fix. @kizu, could you look into this? I think something in |
|
@slang800 I saw that those tests were added here, by @kpdecker: https://github.com/slang800/nib/commit/5c2f1d1c69c013970235950fcd6b3cf35b0d7c87, and there were a lot of commits there, so maybe he could tell what should go there? Is it looks from the tests, there should be the fix for the Also, as I know, old syntax was supported only with I fear I won't have time to fix this issues by myself, but thanks anyway for getting into this issue, hope everything would resolve nicely! |
| list-style-image: -moz-linear-gradient(50deg, #f00, #0f0); | ||
| list-style-image: -ms-linear-gradient(50deg, #f00, #0f0); | ||
| list-style-image: -o-linear-gradient(50deg, #f00, #0f0); | ||
| list-style-image: linear-gradient(40deg, #f00, #0f0); |
There was a problem hiding this comment.
@kizu, the official version of a linear gradient isn't supposed to have a different degree than all of the vendor-prefixed ones, right? ... So the others should be 40deg, rather than 50deg?
There was a problem hiding this comment.
Nope, that's exactly how it should be — when the gradients were unprefixed, the w3c changed the syntax, see this article, for example:
0deg is a gradient line pointing to the top. Angles increase in a clockwise direction. Old angles can be converted to new angles using the formula
new = abs(old−450) mod 360
There was a problem hiding this comment.
ah! thanks for the explanation, that makes much more sense!
small fixes for gradients (another chunk of #192)
… external js function instead of buggy Stylus hacks, fixes #94
…ts to apply the legacy syntax
refactoring + code style fix
New gradients
Gradients
Better usage of vendor helpers
flexbox relies on it
|
ok, all 15 tests pass now! |
removing legacy webkit gradient syntax & other gradient related improvements
see the commit messages for what's going on here
this closes:
and sets up support for Travis CI, which we need to enable.Travis CI is enabled