-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments in @import-ed files are being inappropriately suppressed #1389
Comments
This is done on purpose. As said in #935:
|
Guys, this is really causing problems when a documentation like Kalei (http://kaleistyleguide.com/) is used. It uses comments in order to generate a style documentation. In my case, I use Grunt to generate two files. One of the files is compressed and doesn't have comments - this is the file that gets loaded on the website. The second CSS file is not compressed and it has comments. The style guide reads the uncompressed file and builds a documentation from it. It's not acceptable to use suppressed comments, because they will appear in the compressed file as well. |
Is there a working solution without explicitly mark comments like /*! */ ? The problem with /*! */ is that the stylus compiler can't remove them in further build tasks for production. So I need another CSS minifier to remove the persisted comments. I would suggest an additional build flag to remove persisted comments /*! */ as well if it is needed. |
I agree on Markus suggestion. |
+1 |
In
@import
ed.styl
files, all block comments are being suppressed in the output.There's a closed issue for that https://github.com/LearnBoost/stylus/issues/444 from 2 years ago but It's still not working.
I've created a repo to show this scenario:
https://github.com/vitormil/stylus-comment-bug
The text was updated successfully, but these errors were encountered: