Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for Joule Heating not in configuration file #230

Closed
asdeshpan opened this issue Jan 15, 2016 · 8 comments
Closed

Option for Joule Heating not in configuration file #230

asdeshpan opened this issue Jan 15, 2016 · 8 comments

Comments

@asdeshpan
Copy link

I am trying to include Joule heating as a source term.
Although the source term for Joule heating is defined in numerics_structure.hpp, unlike other source terms (like Wind Gust), it is not allocated in definition_structure.cpp. Also its option is not present in either the config_structure.cpp file or the config_template.cfg file.
Is any modification of code required?

Thanks.

@hlkline
Copy link
Member

hlkline commented Jan 15, 2016

Thanks for identifying this
It sounds like modifying the code will be required to make that option work. Since you have already identified the places in the code which need to be modified, are you interested in making those modifications yourself?
If so, you will find information on how to get started in the wiki at: https://github.com/su2code/SU2/wiki/Developer-Docs

@asdeshpan
Copy link
Author

I am a new developer so I might need some help. I have added some expressions based upon the discussion on cfdonline: http://www.cfd-online.com/Forums/su2/129165-add-source-terms-user-defined-boundary-condition-set-up-transient-simulation.html.
Based upon that discussion, I have allocated the already defined class in definition_structure.cpp:
numerics_container[iMGlevel][FLOW_SOL][SOURCE_FIRST_TERM] = new CSource_JouleHeating(nDim, nVar_Flow, config);

Also, I have referred to the implementation of source term of Wind Gust. To get started, I am trying to implement a Yes/No option to include Joule Heating in the configuration file. I have added the following statements:
config_structure.inl: inline bool CConfig::GetJoule_Heating(void) {return Joule_Heating}
config_structure.hpp: a flag: bool Joule_Heating and bool GetJoule_Heating(void)
config_structure.cpp: addBoolOption("JOULE_HEATING", Joule_Heating, false)

On compiling, I get an error stating that "JOULE_HEATING" is an invalid option name. Please let me know where I am going wrong.
Thanks!

@talbring
Copy link
Member

Sorry to ask this, but where do you find the CSource_JouleHeating class defined in numerics_structure.hpp ?

@asdeshpan
Copy link
Author

You're right, it is not present in the cloned repository in both the files - numerics_direct_mean.cpp and numerics_structure.cpp. But I explored the code using its doxygen documentation. It says it starts from line 4618 in that file.
http://su2.stanford.edu/doxygen/class_c_source___joule_heating.html

@talbring
Copy link
Member

Unfortunately, this doxygen documentation is quite old (based on version 3.0). In the meantime this Joule heating source implementation was removed.

@hlkline
Copy link
Member

hlkline commented Jan 19, 2016

To see doxygen documentation for any version, download the Documentation repository, go to the Doxygen folder, and compile there.
The doxygen input file looks for the code in ../../SU2, so the folder structure should be something like:
home/SU2/
home/Documentation/Doxygen

@asdeshpan
Copy link
Author

Thanks a lot for letting me know! I will look into it

@hlkline
Copy link
Member

hlkline commented Jan 21, 2016

It appears to me that this issue can be closed now; please feel free to reopen if you disagree.

@hlkline hlkline closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants