Add option to disable auto previewing. Allow preview on-demand via new command #30

Merged
merged 1 commit into from Oct 31, 2013

Conversation

Projects
None yet
9 participants
Contributor

terryma commented Mar 27, 2013

This is for issue #29. I ended up implementing it a little differently. Two things to note:

  1. Instead of toggling preview, I simply added command to start the preview. When the buffer exists, the preview stops automatically
  2. I'm not particularly fond of the way the plugin handles multiple markdown buffers with the push/pop logic, so I opted to keep the manual option simple where it only works on the currently edited buffer
Owner

suan commented Mar 30, 2013

Thanks! I'll try to get to this soon

Nice feature, 👍

Amazing, just pasted it in and it works. Great work! Thanks to both of you!

hotoo commented May 18, 2013

Nice

+1 for merging

It'd be a great feature! +1

nippo commented Sep 26, 2013

+1

madx commented Oct 29, 2013

Any news on this?

It's definitely an important feature! :)

Owner

suan commented Oct 29, 2013

Hey guys, sorry I have left this bug open for so long! I did do an initial review way back but didn't merge it in cause there were some things I didn't completely agree with. I am still quite busy but will it a priority to get this resolved within a couple of weeks. Thanks!

Sent from my iPhone

On Oct 29, 2013, at 8:26 AM, François Vaux notifications@github.com wrote:

Any news on this?

It's definitely an important feature! :)


Reply to this email directly or view it on GitHub.

madx commented Oct 29, 2013

FYI I've applied the patch locally and it works like a charm. No doubt you may have some issues though

Thanks for the quick update!

suan merged commit 12a78fa into suan:master Oct 31, 2013

madx commented Oct 31, 2013

💕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment