Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Missing LICENSE and test.py in release tarball #1

Closed
pcpa opened this Issue Sep 15, 2012 · 8 comments

Comments

Projects
None yet
2 participants

pcpa commented Sep 15, 2012

I am working on a flask-silk package for fedora at
https://bugzilla.redhat.com/show_bug.cgi?id=839098
and issues noticed included:

  • Missing LICENSE file in upstream tarball
  • Missing make check or equivalent

License also may be incomplete, as the existing LICENSE file
is only a BSD variant, and may be missing some CC-BY-SA

Owner

sublee commented Sep 15, 2012

Hi Paulo, I'm Heungsub Lee.

Thanks for packaging Flask-Silk. I'll try fix the issues that you requested
soon. But I need an answer about these first:

  • LICENSE must be in the tarball file?
  • What does mean "make clean?"

I'll wait for your reply.

Regards,
Heungsub

2012년 9월 15일 토요일에 Paulo Cesar Pereira de Andrade님이 작성:

I am working on a flask-silk package for fedora at
https://bugzilla.redhat.com/show_bug.cgi?id=839098
and issues noticed included:

  • Missing LICENSE file in upstream tarball
  • Missing make check or equivalent

License also may be incomplete, as the existing LICENSE file
is only a BSD variant, and may be missing some CC-BY-SA

Reply to this email directly or view it on GitHubhttps://github.com/sublee/flask-silk/issues/1.

Heungsub Lee | sublee
A game server programmer at Nexon
Welcome to my homepage http://subl.ee/ and GitHubhttp://github.com/sublee
.
*
*

pcpa commented Sep 15, 2012

Yes, LICENSE should be in the tarball. Also it would be better if there is some clarification if any of the image files are under CC-BY-SA and/or what version.

It is "make check" :-) It should be enough to include test.py in the tarball, better if maing it run without the need to first install Flask-Silk. In my package I changed test.py as s/flaskext.silk/silk/ (because flaskext prefix causes python to not find flaskext.* in the build dir) and set PYTHONPATH to the build/lib/flaskext directory, so that it can run test.py after build.

Owner

sublee commented Sep 16, 2012

Hi Paulo,

I updatedhttps://github.com/sublee/flask-silk/commit/1eafaad43a7797c8dfe4b5f1818057ec720206b4#L0R33LICENSE
but I couldn't include LICENSE and test.py into the tarball file in
PyPI. Because the tarball is generated by "setuptools" not a human. It
archives only source code. Clearly, it includes just the "flaskext" folder.
In my opinion, we should choose a generated tarball file by
GitHubhttps://github.com/sublee/flask-silk/tarball/master
instead.

Let you examine LICENSE and GitHub tarball file.

Regards,
*
*
Heungsub Lee | sublee
A game server programmer at Nexon
Welcome to my homepage http://subl.ee/ and GitHubhttp://github.com/sublee
.
*
*

2012/9/15 Paulo Cesar Pereira de Andrade notifications@github.com

Yes, LICENSE should be in the tarball. Also it would be better if there is
some clarification if any of the image files are under CC-BY-SA and/or what
version.

It is "make check" :-) It should be enough to include test.py in the
tarball, better if maing it run without the need to first install
Flask-Silk. In my package I changed test.py as s/flaskext.silk/silk/
(because flaskext prefix causes python to not find flaskext.* in the build
dir) and set PYTHONPATH to the build/lib/flaskext directory, so that it can
run test.py after build.


Reply to this email directly or view it on GitHubhttps://github.com/sublee/flask-silk/issues/1#issuecomment-8585070.

pcpa commented Sep 16, 2012

I think you should use a MANIFEST.in file to include the LICENSE and test.py in the release tarball.
But I am not much experienced with it. As an example of MANIFEST.in usage, I would suggest looking at another package I made, that was approved for Fedora a few days ago: https://github.com/mitsuhiko/flask-babel

Owner

sublee commented Sep 16, 2012

I did as your advice and it worked. Thanks!

Check new version of the tarball file:
http://pypi.python.org/packages/source/F/Flask-Silk/Flask-Silk-0.1.2.tar.gz#md5=870d42de3cd47775dfde30367b562db2
*
*
Heungsub Lee | sublee
A game server programmer at Nexon
Welcome to my homepage http://subl.ee/ and GitHubhttp://github.com/sublee
.
*
*

2012/9/17 Paulo Cesar Pereira de Andrade notifications@github.com

I think you should use a MANIFEST.in file to include the LICENSE and
test.py in the release tarball.
But I am not much experienced with it. As an example of MANIFEST.in usage,
I would suggest looking at another package I made, that was approved for
Fedora a few days ago: https://github.com/mitsuhiko/flask-babel


Reply to this email directly or view it on GitHubhttps://github.com/sublee/flask-silk/issues/1#issuecomment-8596205.

pcpa commented Sep 16, 2012

Many thanks! The package was updated and built in Fedora rawhide and should be available shortly.

@pcpa pcpa closed this Sep 16, 2012

Owner

sublee commented Sep 16, 2012

Please notify me when all process passes.

2012년 9월 17일 월요일에 Paulo Cesar Pereira de Andrade님이 작성:

Many thanks! The package was updated and built in Fedora rawhide and
should be available shortly.

Reply to this email directly or view it on GitHubhttps://github.com/sublee/flask-silk/issues/1#issuecomment-8596850.

Heungsub Lee | sublee
A game server programmer at Nexon
Welcome to my homepage http://subl.ee/ and GitHubhttp://github.com/sublee
.
*
*

pcpa commented Sep 16, 2012

This link should be short lived http://koji.fedoraproject.org/koji/taskinfo?taskID=4488316 and has links to build logs, etc, and was a successful build.
The package as a requirement of my work in progress sagemath package, so it will be in devel branch only of fedora for significant time.
The package should reach mirrors in the next few days, and be visible, for example in the proper subdirectory (source or arch specific) at http://mirrors.kernel.org/fedora/development/rawhide/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment