Skip to content

Update link_credential_phishing_intent_and_other_indicators.yml #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Update link_credential_phishing_intent_and_other_indicators.yml #2911

wants to merge 8 commits into from

Conversation

@aidenmitchell
Copy link
Member

@aidenmitchell aidenmitchell commented Jul 9, 2025 •
edited
Loading

Description

Removing this rule from the feed, many FPs and little TPs. All known TPs have been covered.

@IndiaAce
Copy link
Member

IndiaAce commented Jul 25, 2025

Curious if we need testing on this? Or just next steps in general. I resolved the merge conflict so we'll need another reviewer!

IndiaAce and others added 3 commits August 22, 2025 08:10
@IndiaAce
Merge branch 'main' into aiden.fp.credphish
bd31e9b
@IndiaAce
Merge branch 'main' into aiden.fp.credphish
02b3699
@alex-herold
Sync .github directory from main branch
dc43877 
- Applied .github directory from main to aiden.fp.credphish
- Ensures workflows and GitHub configurations are up to date
- Automated sync via script
@aidenmitchell
Copy link
Member Author

aidenmitchell commented Nov 3, 2025

Testing now shows that this rule is covered:
https://platform.sublime.security/messages/all-matches?attack_surface_reduction=include&days_back=7&flagged_only=true&flagged_rules_ids=%7B%22019a0dd9-20e2-740d-a6d8-41fcde7bb52b%22%3A%22is%22%7D&page=1&review_status=ALL&status=

All Mimic failures are also resolved: https://www.notion.so/sublimesecurity/Refactor-Credential-phishing-Engaging-language-and-other-indicators-rule-22a04655fc9d80d78b0dfc564cd5af7e?source=copy_link

@aidenmitchell aidenmitchell added review-needed Indicates that a PR is waiting for review and removed do-not-merge labels Nov 3, 2025
@aidenmitchell aidenmitchell marked this pull request as ready for review November 3, 2025 22:39
@aidenmitchell aidenmitchell requested a review from a team as a code owner November 3, 2025 22:39
@github-actions github-actions bot added the in-test-rules PR is in our testing suite to collect telemetry label Nov 3, 2025
github-actions bot added a commit that referenced this pull request Nov 3, 2025
@github-actions
[PR #2911] added rule: Credential phishing: Engaging language and oth…
77e640a 
…er indicators (untrusted sender)
github-actions bot added a commit that referenced this pull request Nov 4, 2025
@github-actions
[PR #2911] Delete detection rule
7ada1e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in-test-rules PR is in our testing suite to collect telemetry review-needed Indicates that a PR is waiting for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidenmitchell @IndiaAce @alex-herold