Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash comment #2367

Closed
haraldh opened this issue May 19, 2020 · 5 comments
Closed

Bash comment #2367

haraldh opened this issue May 19, 2020 · 5 comments

Comments

@haraldh
Copy link

@haraldh haraldh commented May 19, 2020

I think this:

should be:

        - match: '(?=\n)'
          scope: comment.line.number-sign.shell
          pop: true

the effect can be seen with:

echo "Hello World" # comment
echo "Hello World"

which does not color echo again.

@haraldh
Copy link
Author

@haraldh haraldh commented May 19, 2020

as can be seen here, too..
https://harald.hoyer.xyz/console/

@michaelblyons
Copy link
Collaborator

@michaelblyons michaelblyons commented May 19, 2020

Cannot reproduce.

Screen Shot 2020-05-19 at 3 23 23 PM

I have two active branches with Bash changes merged into my live setup: #2309 and a local one to highlight escape characters in strings like the snippet below. Neither should be affecting your bug report.

echo -e "\e[33m+\e[0mAhead and \e[31m-\e[0mBehind commits compared to..."

Edit: Tested master, too, and still NOREPRO.

@haraldh
Copy link
Author

@haraldh haraldh commented May 19, 2020

Ok, thanks! Then let's close this. Must be the syntect engine somehow then..

@haraldh haraldh closed this as completed May 19, 2020
@rwols
Copy link
Contributor

@rwols rwols commented May 19, 2020

Off-topic perhaps, but I think that \n workaround can be removed for st40xx builds.

@FichteFoll
Copy link
Collaborator

@FichteFoll FichteFoll commented May 19, 2020

Since somewhere around 7073, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants