Conversation
|
There’s now a blog post that explains details of package implementation and capabilities https://tonsky.me/blog/sublime-clojure/ Is this PR blocked by failed CI? I tried to look into it but don’t understand if it’s caused by my package, my PR or by CI itself. |
|
There is also LSP with the clojure-lsp language server. |
|
LSP does not provide Eval, which is the main purpose of REPL and this package |
|
1 month anniversary of this PR 🎂 |
I don't like making promises I can't keep, and silence is better than "thanks, we'll maybe look at it eventually". We don't have the capacity currently to properly review more complicated packages, sorry. Maybe have another look at the naming rules? The package otherwise looks mostly ok I guess, it's shame the bot doesn't want to test it for some reason. |
|
Thank you for replying! It’s actually very helpful, even without any promises:
Thanks! RE: name, I have seen the rules but still couldn’t come up with a better name. It’s a package for Clojure, but simple “Clojure” would conflict with built-in package. I am happy to change to “Clojure” if it wouldn’t. RE: using space in the name, documentation says “search indexer will properly split words” but when I run “Install Package” I see lots of names not split: “RustFormat”, “RustAutoComplete” etc. Also lots of packages use space already and don’t seem to have a problems, and I like how it looks with space much more. “SublimeClojure” or “sublime_clojure” both look like package name made for computers, “Sublime Clojure” looks like it was made for humans. I would change it if it’s a stopper, of course, but if it’s just a recommendation, I would like to keep “Sublime Clojure”. |
|
The space isn't a problem, as you noticed plenty of packages use a space. "Sublime Clojure" doesn't communicate anything, the default "Clojure" is also "Sublime" 😉. We usually see something like "Better Clojure" or "Clojure Improved". |
|
"Clojure Sublimed" 🤔 ? |
It's a very strong recommendation: if we don't uphold that guideline we just get more and more package with the Sublime prefix. In the context of package control, which is what we're talking about here, "Sublime" is truly an empty term and just adds noise. |
|
Renamed to Clojure Sublimed |
|
Thank you 🙏 🙏 🙏 🎉 🎉 🎉 |
Checklist
tags: trueAbout
Sublime Clojure is nREPL client and syntax definition for Clojure. Latter is required for REPL to operate: detect form boundaries, find namespace symbol. nREPL is the most popular REPL server in Clojure ecosystem.
The main features of this plugin are inline evaluation (via annotations and phantoms) and convenience (parallel evaluation, formatted stacktraces, execution time)
Similar packages
Sublime REPL:
Tutkain:
(+ 1 2)*out*/*err*toSystem.out/System.errThanks!