When the input panel is closed by `enter` the `hide_panel` command is not called

[evandrocoan]

Actual behavior

The hide_panel event is not called by the enter key, when it is pressed on the current panel, causing it to close.

Steps to reproduce

1. Create the package bug.py on your User folder.

   import sublime, sublime_plugin
   
   class HidePanelBugListener(sublime_plugin.EventListener):
   
       def on_post_window_command(self, window, command, args):
   
           if command == "hide_panel":
               print( "on_post_window_command hide_panel" )
   
   def on_cancel():
       print( "Cancelling" )
       pass
   
   def on_done(self):
       print( "Done" )
   
   
   def on_change(self):
       print( "Change" )
       pass
   
   class HidePanelBugCommand(sublime_plugin.WindowCommand):
   
       def run(self):
           sublime.active_window().show_input_panel( \
                      "To bug it, press enter: ", "", on_done, on_change, on_cancel )

2. Open Sublime Text console Ctrl+' and run the command
   sublime.active_window().run_command( "hide_panel_bug" )

3. If you press enter, you will get the output:

   >>> sublime.active_window().run_command( "hide_panel_bug" )
   Change
   Done
   

4. If you press escape, you will get the output:

   >>> sublime.active_window().run_command( "hide_panel_bug" )
   Change
   on_post_window_command hide_panel
   Cancelling
   

Expected behavior

When I open the input panel I am expecting to receive the hide_panel event when it is closed, either by the escape key, either by the enter key.

1. If you press enter, you will get the output:

   >>> sublime.active_window().run_command( "hide_panel_bug" )
   Change
   on_post_window_command hide_panel
   Done
   

2. If you press escape, you will get the output:

   >>> sublime.active_window().run_command( "hide_panel_bug" )
   Change
   on_post_window_command hide_panel
   Cancelling
   

Environment

• Operating system and version:
  • Windows 10 build 15063
  • Mac OS ...
  • Linux ...
• Monitor:
  • Resolution 1920x1080
  • dpi_scale used in ST 1.0
• Sublime Text:
  • Build 3141
  • 32 bit

---

Related issues:

1. Input panel closes when completions visible and press enter #1727 Input panel closes when completions visible and press enter

[evandrocoan]

Posting @r-stein point on the forum about this:

Just to explain it as I understand it: The listener listens to commands and not to actions, so you listen to the hide_panel command, which is executed when pressing escape. The enter key is handled internally and does not trigger a command. This has the disadvantages, that you cannot bind an other key to enter, bind enter to a different command, or listen to its execution. The enhancement would be to transform enter into a confirm_panel command. So backward compatibility wouldn't be a major issue.

https://forum.sublimetext.com/t/open-source-sublime-text/29950/14

Thinking like this, makes feels like this issue with the enter key was already posted before around here.

[keith-hall]

For the same reasons, I also made a request for clicking on an autocompletion entry to trigger the commit_completion command: #1166