Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find in files panel should signal about many lines of replacement text #2375

Closed
KES777 opened this issue Jul 10, 2018 · 5 comments
Closed

find in files panel should signal about many lines of replacement text #2375

KES777 opened this issue Jul 10, 2018 · 5 comments
Labels

Comments

@KES777
Copy link

@KES777 KES777 commented Jul 10, 2018

Summary

find panel does not show how many lines in replacement

Expected behavior

find panel should signal that more than one line will be inserted

Steps to reproduce

  1. open find panel

delete1

for example this replacement consist of eight lines

@randy3k

This comment has been minimized.

Copy link

@randy3k randy3k commented Jul 10, 2018

It is the Find in Files... search panel and it cannot show you how many matches are there over the searching directory. You should use Replace.. if the search only applies to a particular document and it tells how many matches there are.

@KES777

This comment has been minimized.

Copy link
Author

@KES777 KES777 commented Jul 10, 2018

sorry for my english. I am telling that Replace input has few lines:

extends 'HyperMouse::Schema::Result';
extends 'HyperMouse::Schema::Result';
extends 'HyperMouse::Schema::Result';

When I insert extends 'HyperMouse::Schema::Result'; first time the new line character just move whole string up and visually Replace has nothing. I insert again, again... then type it manually.

Finally when replacement is finished I get wrong result at almost 100 files:
delete1

and there is no, as far as I know, CTRL+Z

Thus I ask about ability to highlight that Replace already have some searching maybe by just adding an half of an line to the height of Replace input filed

@randy3k

This comment has been minimized.

Copy link

@randy3k randy3k commented Jul 10, 2018

OIC, it is about visualization clue about multiline input.

@keith-hall keith-hall changed the title find panel should signal about many lines find in files panel should signal about many lines of replacement text Jul 11, 2018
@keith-hall

This comment has been minimized.

Copy link
Collaborator

@keith-hall keith-hall commented Jul 12, 2018

Note that the find and replace panel auto-resizes to cater for multi-line input, and the find in files panel doesn't. Apart from that, it is resizable by hand still, so that can be a workaround for now because it remembers the size you set.

@keith-hall

This comment has been minimized.

Copy link
Collaborator

@keith-hall keith-hall commented Aug 1, 2018

duplicate of #736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.