`window.set_layout` moves the focus

[kaste]

Description

Splitting a new window, for example window.set_layout( { "cols": [0.0, 0.5, 1.0], "rows": [0.0, 1.0], "cells": [[0, 0, 1, 1], [1, 0, 2, 1]] } ), focuses the right pane. After that, a window.new_file() creates a view in the right pane.

In ST3, this wasn't the case.

Notable: If you use the above set_layout right in the console, the focus is stolen from the console.

This is a bug for (e.g.) the popular Compare Side-By-Side plugin.

• Build: 4106
• Operating system and version: Windows 10

[deathaxe]

I guess it's related with the request of #3743 which exectly asked for this behavior. Not sure about API behavior though.

[kaste]

Yeah, totally. Doing it with the shortcut of course did focus the second or last pane. But the raw API did as few things as possible.

[deathaxe]

Maybe those implementations got merged so that any end point uses same implementation now?

A plugin can always call set_focus explicitly so I agree, window.set_layout() leaving focus untouched may be a more flexible solution. It at least may break existing plugins as you mensioned.

Already wondered why "Compera Side-By-Side" behaves so strange. Always liked that plugin to quickly compare files.

[kaste]

The API used to be low-level, and you always had to call three functions to make one thing which of course also annoyed users. Maybe it is better to make high level API's, t.i. typical functionality in one handy function, to make the end-users life easier as well. There is porcelain and there is plumbing. Just from my experience, I don't remember a real API bug for which I had to make a complicated workaround in GitSavvy or SublimeLinter. I always just had to add more code, I had to be more specific and precise in using the API.