Add lombok support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDAP
force-pushed
the
feature/lombok
branch
2 times, most recently
from
d663ed5
to
d93624f
Compare
rchl
reviewed
Jun 26, 2022
| def on_pre_start(cls, window: sublime.Window, initiating_view: sublime.View, | ||
| workspace_folders: List[WorkspaceFolder], configuration: ClientConfig) -> Optional[str]: | ||
| javaagent_arg = "-javaagent:" + lombok_path(cls.storage_subpath()) | ||
| # Prevent adding the argument multiple times |
There was a problem hiding this comment.
I don't think the case when argument is added multiple times should be possible as on_pre_start should be always called with freshly created config. Did you see it happening when testing?
There was a problem hiding this comment.
Yes I discovered that issue while testing. Every time I executed the restart server command the argument was readded.
There was a problem hiding this comment.
Troubleshoot Server command does add the argument too.
There was a problem hiding this comment.
@rwols Should I open an issue in sublimelsp/LSP or is this intended behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10