Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid GlobalnetCidrRange during subctl deploy-broker #1668

Closed
jinglina opened this issue Nov 19, 2021 · 0 comments · Fixed by #1669
Closed

Invalid GlobalnetCidrRange during subctl deploy-broker #1668

jinglina opened this issue Nov 19, 2021 · 0 comments · Fixed by #1669
Labels
bug Something isn't working

Comments

@jinglina
Copy link
Contributor

What happened:
errros when deploy broker using subctl (version: 0.10.1)

E1119 01:53:34.223223       1 controller.go:267] controller-runtime/manager/controller/broker "msg"="Reconciler error" "error"="invalid GlobalnetCidrRange: invalid CIDR address: " "name"="submariner-broker" "namespace"="submariner-operator" "reconciler group"="submariner.io" "reconciler kind"="Broker"

when globalnet is desabled, globalnetInfo.GlobalnetCidrRange is empty,
when check net.parse(), it reports an error

if globalnetInfo != nil {
		if err = IsValidCIDR(globalnetInfo.GlobalnetCidrRange); err != nil {
			return fmt.Errorf("invalid GlobalnetCidrRange: %s", err)
		}
	}

What you expected to happen:
the error not occurs again.
How to reproduce it (as minimally and precisely as possible):
subctl deploy-broker
Anything else we need to know?:

Environment:

  • Diagnose information (use subctl diagnose all):
  • Gather information (use subctl gather)
  • Cloud provider or hardware configuration:
  • Install tools:
  • Others:
@jinglina jinglina added the bug Something isn't working label Nov 19, 2021
@tpantelis tpantelis changed the title invalid GlobalnetCidrRange whne subctl deploy-broker Invalid GlobalnetCidrRange during subctl deploy-broker Nov 19, 2021
@dfarrell07 dfarrell07 modified the milestone: 0.12 Nov 23, 2021
@dfarrell07 dfarrell07 added this to In Review in Submariner Project 0.12 Nov 23, 2021
@maayanf24 maayanf24 moved this from In Review to Done in Submariner Project 0.12 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants