-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subctl doesn’t pass K8s configs/contexts to kubectl and kubefedctl #180
Comments
skitt
added a commit
to skitt/submariner-operator
that referenced
this issue
Feb 19, 2020
Currently, subctl runs kubectl and kubefedctl in the default context: whichever kubeconfig is the default, and whichever context is the default. If the user specifies --kubeconfig and/or --kubecontext on the subctl command-line, this causes mix-ups since subctl and the other tools don’t touch the same cluster. With this patch, kubectl and kubefedctl are given the appropriate flags as necessary. This isn’t particularly elegant but it will all be removed once KubeFed is removed. Fixes: submariner-io#180 Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this issue
Feb 19, 2020
Currently, subctl runs kubectl and kubefedctl in the default context: whichever kubeconfig is the default, and whichever context is the default. If the user specifies --kubeconfig and/or --kubecontext on the subctl command-line, this causes mix-ups since subctl and the other tools don’t touch the same cluster. With this patch, kubectl and kubefedctl are given the appropriate flags as necessary. This isn’t particularly elegant but it will all be removed once KubeFed is removed. Fixes: submariner-io#180 Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this issue
Feb 20, 2020
Currently, subctl runs kubectl and kubefedctl in the default context: whichever kubeconfig is the default, and whichever context is the default. If the user specifies --kubeconfig and/or --kubecontext on the subctl command-line, this causes mix-ups since subctl and the other tools don’t touch the same cluster. With this patch, kubectl and kubefedctl are given the appropriate flags as necessary. This isn’t particularly elegant but it will all be removed once KubeFed is removed. Fixes: submariner-io#180 Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
to skitt/submariner-operator
that referenced
this issue
Feb 21, 2020
Currently, subctl runs kubectl and kubefedctl in the default context: whichever kubeconfig is the default, and whichever context is the default. If the user specifies --kubeconfig and/or --kubecontext on the subctl command-line, this causes mix-ups since subctl and the other tools don’t touch the same cluster. With this patch, kubectl and kubefedctl are given the appropriate flags as necessary. This isn’t particularly elegant but it will all be removed once KubeFed is removed. Fixes: submariner-io#180 Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
added a commit
that referenced
this issue
Feb 24, 2020
Currently, subctl runs kubectl and kubefedctl in the default context: whichever kubeconfig is the default, and whichever context is the default. If the user specifies --kubeconfig and/or --kubecontext on the subctl command-line, this causes mix-ups since subctl and the other tools don’t touch the same cluster. With this patch, kubectl and kubefedctl are given the appropriate flags as necessary. This isn’t particularly elegant but it will all be removed once KubeFed is removed. Fixes: #180 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In scenarios where
subctl
needs other tools (kubectl
andkubefedctl
, as used for Lighthouse), it doesn’t pass parameters to specify the configuration to use, so the whole setup only works ifKUBECONFIG
etc. are set appropriately externally.The text was updated successfully, but these errors were encountered: