Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subctl flag to accept "Enabling service discovery on OpenShift" #235

Closed
manosnoam opened this issue Mar 5, 2020 · 0 comments · Fixed by #237
Closed

subctl flag to accept "Enabling service discovery on OpenShift" #235

manosnoam opened this issue Mar 5, 2020 · 0 comments · Fixed by #237
Assignees
Labels
automation enhancement New feature or request subctl Subctl related issues

Comments

@manosnoam
Copy link

Please add a flag to auto-accept "Enabling service discovery on OpenShift will disable OpenShift updates, do you want to continue?" when running subctl deploy with --service-discovery.

@manosnoam manosnoam added automation enhancement New feature or request labels Mar 5, 2020
@mangelajo mangelajo added the subctl Subctl related issues label Mar 5, 2020
@skitt skitt self-assigned this Mar 5, 2020
@skitt skitt added this to Backlog in Submariner Project v0.2.0 + v0.1.1 via automation Mar 5, 2020
@skitt skitt moved this from Backlog to In progress in Submariner Project v0.2.0 + v0.1.1 Mar 5, 2020
skitt added a commit to skitt/submariner-operator that referenced this issue Mar 5, 2020
When subctl determines that the OpenShift CVO needs to be disabled, it
asks for confirmation; this patch allows skipping this check (and
forcing the CVO to be disabled, if necessary) with --disable-cvo.

Fixes: submariner-io#235
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Submariner Project v0.2.0 + v0.1.1 automation moved this from In progress to Done Mar 5, 2020
mangelajo pushed a commit that referenced this issue Mar 5, 2020
When subctl determines that the OpenShift CVO needs to be disabled, it
asks for confirmation; this patch allows skipping this check (and
forcing the CVO to be disabled, if necessary) with --disable-cvo.

Fixes: #235
Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit to skitt/submariner-operator that referenced this issue Mar 5, 2020
When subctl determines that the OpenShift CVO needs to be disabled, it
asks for confirmation; this patch allows skipping this check (and
forcing the CVO to be disabled, if necessary) with --disable-cvo.

Fixes: submariner-io#235
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit df680be)
mangelajo pushed a commit that referenced this issue Mar 5, 2020
When subctl determines that the OpenShift CVO needs to be disabled, it
asks for confirmation; this patch allows skipping this check (and
forcing the CVO to be disabled, if necessary) with --disable-cvo.

Fixes: #235
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 52a6b94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation enhancement New feature or request subctl Subctl related issues
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants