build: migrate the CRDs to v1 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMattar
requested review from
mangelajo,
mkolesnik,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr789/SteveMattar/crds-v1 |
Closed
Closed
skitt
requested changes
Nov 10, 2020
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
dfarrell07
reviewed
Nov 10, 2020
skitt
requested changes
Nov 10, 2020
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
|
I'm not sure what's going wrong, but these failures seem like real errors, not flaky failures or failures due to something else. |
|
@dfarrell07 yes I'm on it. Perhaps I should convert this PR to draft |
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
1 similar comment
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
Signed-off-by: Steve Mattar <smattar@redhat.com>
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
skitt
approved these changes
Nov 12, 2020
dfarrell07
approved these changes
Nov 12, 2020
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
|
🤖 Updated branch: z_pr789/SteveMattar/crds-v1 |
|
🤖 Closed branches: [z_pr789/SteveMattar/crds-v1] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
controller-gento generate the CRDs in v1.Signed-off-by: Steve Mattar smattar@redhat.com