Allow setting TCP MSS clamping value also for non GN #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yboaron
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2087/yboaron/clamp_non_gn |
nyechiel
added
backport
sridhargaddam
approved these changes
Oct 27, 2022
| @@ -62,7 +62,7 @@ var logger = log.Logger{Logger: logf.Log.WithName("MTU")} | |||
|
|
|||
| func NewMTUHandler(localClusterCidr []string, isGlobalnet bool, tcpMssValue int) event.Handler { | |||
| forceMss := notNeeded | |||
| if isGlobalnet { | |||
| if isGlobalnet || tcpMssValue != 0 { | |||
There was a problem hiding this comment.
Not in the scope of this PR, but we should probably add some validation on the MTU value that is configured by the user (i.e., to ensure that its in the valid reasonable range)
nyechiel
approved these changes
Oct 28, 2022
|
This would need a backport to both |
We noticed in some cases MTU issues even when GN was disabled. This PR allows the user to force a particular MSS clamping value also for non GN. To force a particular MSS clamping value use the submariner.io/tcp-clamp-mss node annotation on Gateway nodes. e.g. kubectl annotate node <node_name> submariner.io/tcp-clamp-mss=<value> Signed-off-by: Yossi Boaron <yboaron@redhat.com>
sridhargaddam
force-pushed
the
clamp_non_gn
branch
from
fceea87
to
1186509
Compare
This was referenced Oct 28, 2022
|
🤖 Closed branches: [z_pr2087/yboaron/clamp_non_gn] |
sridhargaddam
pushed a commit
to sridhargaddam/submariner
that referenced
this pull request
Oct 28, 2022
) We noticed in some cases MTU issues even when GN was disabled. This PR allows the user to force a particular MSS clamping value also for non GN. To force a particular MSS clamping value use the submariner.io/tcp-clamp-mss node annotation on Gateway nodes. e.g. kubectl annotate node <node_name> submariner.io/tcp-clamp-mss=<value> Signed-off-by: Yossi Boaron <yboaron@redhat.com> (cherry picked from commit 9e47bd0)
sridhargaddam
pushed a commit
to sridhargaddam/submariner
that referenced
this pull request
Oct 28, 2022
) We noticed in some cases MTU issues even when GN was disabled. This PR allows the user to force a particular MSS clamping value also for non GN. To force a particular MSS clamping value use the submariner.io/tcp-clamp-mss node annotation on Gateway nodes. e.g. kubectl annotate node <node_name> submariner.io/tcp-clamp-mss=<value> Signed-off-by: Yossi Boaron <yboaron@redhat.com> (cherry picked from commit 9e47bd0)
tpantelis
pushed a commit
that referenced
this pull request
Oct 28, 2022
We noticed in some cases MTU issues even when GN was disabled. This PR allows the user to force a particular MSS clamping value also for non GN. To force a particular MSS clamping value use the submariner.io/tcp-clamp-mss node annotation on Gateway nodes. e.g. kubectl annotate node <node_name> submariner.io/tcp-clamp-mss=<value> Signed-off-by: Yossi Boaron <yboaron@redhat.com> (cherry picked from commit 9e47bd0)
tpantelis
pushed a commit
that referenced
this pull request
Oct 28, 2022
We noticed in some cases MTU issues even when GN was disabled. This PR allows the user to force a particular MSS clamping value also for non GN. To force a particular MSS clamping value use the submariner.io/tcp-clamp-mss node annotation on Gateway nodes. e.g. kubectl annotate node <node_name> submariner.io/tcp-clamp-mss=<value> Signed-off-by: Yossi Boaron <yboaron@redhat.com> (cherry picked from commit 9e47bd0)
sridhargaddam
added
the
release-note-needed
yboaron
added a commit
to yboaron/submariner
that referenced
this pull request
Nov 3, 2022
yboaron
added a commit
to yboaron/submariner
that referenced
this pull request
Nov 3, 2022
yboaron
added a commit
to yboaron/submariner
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Yossi Boaron <yboaron@redhat.com>
tpantelis
pushed a commit
that referenced
this pull request
Nov 7, 2022
Signed-off-by: Yossi Boaron <yboaron@redhat.com>
dfarrell07
removed
the
release-note-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed in some cases MTU issues even when
GN was disabled.
This PR allows the user to force a particular MSS clamping value
also for non GN.
To force a particular MSS clamping value use the submariner.io/tcp-clamp-mss
node annotation on Gateway nodes.
e.g. kubectl annotate node <node_name> submariner.io/tcp-clamp-mss=<value>
Signed-off-by: Yossi Boaron yboaron@redhat.com