Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmenter #4

Closed
wants to merge 7 commits into from
Closed

Augmenter #4

wants to merge 7 commits into from

Conversation

@FranzHahn
Copy link
Collaborator

FranzHahn commented Mar 25, 2020

handled issues #1 , #2 and #3 .

@subpic
subpic approved these changes Mar 25, 2020
@subpic
subpic approved these changes Mar 25, 2020
@subpic
subpic approved these changes Mar 25, 2020
@subpic
subpic approved these changes Mar 25, 2020
Copy link
Owner

subpic left a comment

get_patch_dims is a generic utility function that does not require access to an image per se. It is sufficient for it to know the size of the image (width, height). The first argument can then be the size of the image, rather than the image itself.

Copy link
Owner

subpic left a comment

In def cropout_patch(im, patch_size=(224, 224), X1 and Y1 are used without being initialized? Am I reading this correctly?

@FranzHahn

This comment has been minimized.

Copy link
Collaborator Author

FranzHahn commented Mar 25, 2020

In def cropout_patch(im, patch_size=(224, 224), X1 and Y1 are used without being initialized? Am I reading this correctly?

Should be fixed. I also added tests and sanity checks.

@subpic
subpic approved these changes Mar 25, 2020
@subpic
subpic approved these changes Mar 25, 2020
@subpic
subpic approved these changes Mar 25, 2020
@subpic
subpic approved these changes Mar 25, 2020
@subpic

This comment has been minimized.

Copy link
Owner

subpic commented Mar 26, 2020

Integrated by separate commits.

@subpic subpic closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.