Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for boundary spinning #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cwgreene
Copy link

@cwgreene cwgreene commented Apr 23, 2013

This also contains some code that will make it easier to define arbitrary boundaries for lines.

By having the particles stop at the first point where they
cross the boundary line, we prevent the artificial torque
exerted on the semi-rigid body.
@subprotocol
Copy link
Owner

subprotocol commented Apr 24, 2013

This is great! One comment is inline. Also:

I appear to be using tabs for spacing. It looks like your editor is using spaces. Could you switch to use tabs so that the indentations match?

line 165: https://github.com/cwgreene/verlet-js/blob/master/js/verlet-js/verlet.js we may no longer need this block, as I think the groundFriction would be moved into your bounds function.

@cwgreene
Copy link
Author

cwgreene commented Apr 26, 2013

Sure, hopefully can get around to it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants