Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Update.Where() method discards comparison operator. #210

Closed
toptensoftware opened this Issue · 1 comment

2 participants

@toptensoftware

The fluent api Update.Where() method doesn't copy the constraint comparison operator.

So

Where( x => x.field > 100)

generates SQL

WHERE ' field ' = 100

NB: Should be > 100

Also, it's very easy to inadvertently call this method instead of the generic extension method Where<>(), resulting in more complex expression being discarded without warning.

eg:

Where(x=> x.field1<100 && x.field2>100

generates

WHERE 'field1' = 100;

(the second condition is silently discarded).

Suggest rename or deprecate this method.

@saintedlama
Collaborator

Fixed

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.