Subspace v1 #1
Closed
Subspace v1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p with upcoming refactoring
…ector to file once at the very end
…alled from multiple threads
|
This PR is not meant to be merged, this is just for review purposes |
dariolina
reviewed
Mar 14, 2023
| fn basic() { | ||
| let table = Table::generate(&SEED); | ||
|
|
||
| assert!(table.find_quality(0).is_none()); |
There was a problem hiding this comment.
A minor question: does quality/proof never exist for challenge_index = 0, or is it a coincidence? I'd add a note to the spec to have start_index and s-bucket numeration start at 1 or be one-off
There was a problem hiding this comment.
Have not tried other seeds, why does it matter?
There was a problem hiding this comment.
Pedantry, mostly. If the table never has an entry at 0, it makes no sense to query for 0 for every record. According to design doc it should exist. This is not a concern for this PR just some minor thing to check.
|
Looks good to me functionality-wise |
1 task
nazar-pc
force-pushed
the
subspace-v1
branch
2 times, most recently
from
a8ac93f
to
cf37dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look whether you see any major issues.
CI is happy, will start testing in monorepo now.