Alpha custom types #11
Conversation
There was a problem hiding this comment.
Last commit shouldn't have been here. It is better not to mix formatting PR with feature PR like this one, it makes PR bigger than necessary and harder to review for no reason.
Also please hold on merging it, we need to merge alpha to main first to avoid re-reviewing these feature changes and formatting updates alongside with changes in alpha many more times.
| @@ -135,42 +136,43 @@ export const Client = async () => { | |||
| client.do.blockSubscription.stop() | |||
| }, | |||
| async start() { | |||
| if (!client.api) throw (Error("Api Missing, can't start block subscription yet.")) | |||
| if (!client.api) throw (Error(`Api Missing, can't start block subscription yet.`)) | |||
There was a problem hiding this comment.
Why change to template string literal if there is no interpolation?
There was a problem hiding this comment.
Last commit shouldn't have been here. It is better not to mix formatting PR with feature PR like this one, it makes PR bigger than necessary and harder to review for no reason.
Will have this in consideration for future commits and work on formats and cleaning in separate PR's.
Why change to template string literal if there is no interpolation?
Should i just use back slash on the can't single quote?
There was a problem hiding this comment.
Hm, is it required by linter? If not, I'd leave the way it was, but it is a minor nitpick.
|
I explicitly asked not to merge this before The whole idea was to have reasonably sized PRs that can be merged one by one instead of having a huge one that is hard to review, hard to resolve requested changes and hard to merge. By merging more stuff into Every time a piece of code is changed in existing PR, reviewer needs to:
^ is counter-productive for everyone involved. |
|
Sorry for the confusion, In order to resolve your comments on the alpha branch I need the changes from this branch to be merged. Otherwise there will be massive conflicts merging this branch later. |
This PR add custom types for requested features: Peers and Block Author information, so they can be used by John in the farmer interface.
s.