Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Too strict regular expression #12

wants to merge 1 commit into


None yet
1 participant

ashnur commented May 26, 2013

I think if the code is 0, and the Success message is there, any other kind of output should be ignored. If the browser still does not work, that should be an extreme edge-case, which should be the concern of the user. My issue however is a very common one, and because the browser otherwise works as intended, I think it can be safely ignored.

vweevers pushed a commit to vweevers/browser-launcher that referenced this pull request Jun 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment