Allow dnode to shim in stuff for networked garbage collection #8

Open
wants to merge 8 commits into
from

3 participants

@thejh

Allow dnode to shim in stuff for networked garbage collection. Breaks no tests that worked before.

@substack
Owner

These patches break a lot of tests.

@thejh

Oh, I only ran the dnode tests. Damn.

@thejh

Doesn't seem to be an issue, I just begin counting at a different index.

@thejh

Actually, there are also test failures because I changed some data structures. I'll look at that later.

@thejh

Heh, actually, I think I fixed your code to behave according to your spec. :D Readme says that callbacks should be an object, but test/scrub.js:10 and some more tests want it to be an array.

@thejh

Fixed a mistake by me that prevented culling from working properly and changed a lot in two tests. Does this look good?

@temsa

need !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment