Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add Response#setEncoding #10

wants to merge 1 commit into


None yet
7 participants

tellnes commented Aug 5, 2012

No description provided.

Jxck commented Sep 9, 2014


@MiguelCastillo MiguelCastillo referenced this pull request in danwrong/restler Sep 9, 2014


response.setEncoding missing when using Browserify #161

acgray commented Sep 16, 2014


kumavis commented Jan 18, 2015

better than nothing +1

guasek commented Jan 18, 2015



tellnes commented Jan 29, 2015

I'll rebase this if one with commit bit says it will be merged.

shergin commented Jun 7, 2015


@jamestalmage jamestalmage added a commit to jamestalmage/node-github that referenced this pull request Jun 30, 2015

@jamestalmage jamestalmage make it work with browserify
The main issue preventing browserify usage was computed paths
in require statements: `require("./" + someVariable)`. Those have
all been eliminated.

This patch only adds browser support for `v3.0.0` (see the throwing
code in `/index.js` where it states exactly that to understand why).
Hint: it's related to computed paths again.

There were also a number of issues in `browserify-http`, and
`browserify-https` that I needed to code around to get things working:

  - substack/https-browserify#1
  - substack/http-browserify#90
  - substack/http-browserify#21
  - substack/http-browserify#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment