replace params.scheme with params.protocol #42

wants to merge 2 commits into


None yet

2 participants


When passing an url string to https-browserify, a http request was send off. This commit simplifies the code and fixes that bug.

@hendrikcech hendrikcech referenced this pull request in substack/https-browserify Apr 14, 2014

fix: https.get would make a http request #1


this looks like it actually complicates the code - what bug does this fix? Probably should add a test to exercise it


It needs to be more complicate to be backwards compatible.
This change is necessary to be consistent with the node api. It's also connected to this bug: substack/https-browserify#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment