Skip to content

Fixes build for 0.11 #27

Open
wants to merge 4 commits into from

2 participants

@freeeve
freeeve commented Jul 23, 2013

Solves #26

@freeeve
freeeve commented Jul 23, 2013

Not sure if you appreciate the #if part, but apparently to clear up the warnings with the deprecated calls, it uses new versions that don't exist in the old v8 Persistent<T>::New() (not compatible with 0.10). With the #if check it works in both 0.10 and 0.11 at least, and probably 0.8 (travis says it does).

@taoeffect

This doesn't work on my computer (10.9.1, node v0.11.9):

$ npm install -g https://github.com/wfreeman/node-bigint/tarball/master
npm http GET https://github.com/wfreeman/node-bigint/tarball/master
npm http 200 https://github.com/wfreeman/node-bigint/tarball/master

> bigint@0.4.2 install /usr/local/share/npm/lib/node_modules/bigint
> node-gyp configure build

  CXX(target) Release/obj.target/bigint/bigint.o
../bigint.cc:58:16: error: expected class name
class BigInt : ObjectWrap {
               ^
../bigint.cc:75:34: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> New(const Arguments& args);
                                               ^~~~~~~~~
                                               v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../bigint.cc:76:39: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> ToString(const Arguments& args);
                                                    ^~~~~~~~~
                                                    v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../bigint.cc:77:35: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> Badd(const Arguments& args);
                                                ^~~~~~~~~
                                                v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../bigint.cc:78:35: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> Bsub(const Arguments& args);
                                                ^~~~~~~~~
                                                v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../bigint.cc:79:35: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> Bmul(const Arguments& args);
                                                ^~~~~~~~~
                                                v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../bigint.cc:80:35: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> Bdiv(const Arguments& args);
                                                ^~~~~~~~~
                                                v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
../bigint.cc:81:35: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
                static Handle<Value> Uadd(const Arguments& args);
                                                ^~~~~~~~~
                                                v8::internal::Arguments
/Users/gslepak/.node-gyp/0.11.9/deps/v8/include/v8.h:141:7: note: 'v8::internal::Arguments' declared here
class Arguments;
      ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.