Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support filenames in browser-pack #397

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

SLaks commented May 9, 2013

Defaults to true

Requires SLaks/browser-pack@de48689

Without this PR, browser-pack will only be able to see filenames if source maps are enabled.

@SLaks SLaks referenced this pull request in substack/browser-pack May 9, 2013

Closed

Support full module API #14

@SLaks SLaks added a commit to SLaks/racer that referenced this pull request May 14, 2013

@SLaks SLaks Upgrade to Browserify v2
This requires the following unmerged pull requests:

substack/node-browserify#397
substack/node-browserify#399
substack/browser-pack#14

It is still not fully tested; Browserify v2 does not work well on
Windows.
3b376de
Owner

substack commented Dec 19, 2013

I'm not sure why this PR depends on fully supporting the module.parents and module.filename APIs. It seems like this patch could be done without those.

@substack substack closed this Dec 19, 2013

Contributor

SLaks commented Dec 19, 2013

IIRC, that was to make sure that id contains the full path. (I haven't looked at this code in ages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment