Skip to content

Use `fs.writeFileSync`. #2

Merged
merged 1 commit into from Jun 7, 2012

2 participants

@domenic
domenic commented Jun 6, 2012

This makes Browserify caching actually work (maybe a Windows-only fix?). Without it the cache.json file was always empty.

I am not sure exactly why it was necessary, but it is at least consistent with the rest of the file, which also uses fs.*Sync methods.

@domenic domenic Use `fs.writeFileSync`.
This makes Browserify caching actually work (maybe a Windows-only fix?). I am not sure exactly why, but it is at least consistent with the rest of the file, which also uses `fs.*Sync` methods.
663af38
@domenic domenic added a commit to YuzuJS/WinningJS-todo that referenced this pull request Jun 6, 2012
@domenic domenic Cache Browserify AST traversals.
Depends on substack/node-deputy#2 being accepted before this actually does anything.
1e7a044
@domenic domenic referenced this pull request in YuzuJS/WinningJS-todo Jun 6, 2012
Closed

Build faster! #6

@substack substack merged commit 663af38 into substack:master Jun 7, 2012
@substack
Owner
substack commented Jun 7, 2012

Wow great find! This sped up running the browserify test suite from 0m56.994s to 0m21.529s.

@domenic domenic referenced this pull request in substack/node-browserify Jun 7, 2012
Closed

Use newer deputy so caching works/is fast. #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.