New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly specify esprima dependency #24

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@bdimcheff
Copy link
Collaborator

bdimcheff commented Sep 24, 2013

You still need to specify bundleDependencies in dependencies, or npm shrinkwrap will fail. Try making a silly project with just falafel in package.json, npm install, and npm shrinkwrap. It will fail with an extraneous dependency error for esprima. This issue effectively makes it impossible to use falafel in any project that uses shrinkwrapping.

explicitly specify esprima dependency
You still need to specify bundleDependencies in dependencies, or npm
shrinkwrap will fail.  Try making a silly project with just falafel in
package.json, npm install, and npm shrinkwrap.  It will fail with an
extraneous dependency error for esprima.  This issue effectively makes
it impossible to use falafel in any project that uses shrinkwrapping.
@tellnes

This comment has been minimized.

Copy link

tellnes commented Dec 30, 2013

This also fixes npm prune from breaking falafel and npm ls from calling esprima extraneous.

@wheresrhys

This comment has been minimized.

Copy link

wheresrhys commented Jan 20, 2014

+1

@mjpizz

This comment has been minimized.

Copy link

mjpizz commented Jan 28, 2014

I ran into this issue again today - @substack what do you think?

@michaelgilley

This comment has been minimized.

Copy link

michaelgilley commented Jan 30, 2014

+1

@mjpizz

This comment has been minimized.

Copy link

mjpizz commented Feb 19, 2014

@substack what do you think? Looks like other people are having this issue, and another solution that works just as well is #29. Either way it kind of sucks that I have to hotpatch falafel every time I want to run "npm shrinkwrap" :(

zpao added a commit to facebook/react that referenced this pull request Feb 20, 2014

shrinkwrap
Had to work around bug in falafel preventing shrinkwrap by editing
node_modules/coverify/node_modules/falafel/package.json to declare esprima as
a dependency. cf. substack/node-falafel#24
@palamccc

This comment has been minimized.

Copy link

palamccc commented Jun 6, 2014

+1

@joeellis

This comment has been minimized.

Copy link

joeellis commented Aug 29, 2014

image

@ehynds

This comment has been minimized.

Copy link

ehynds commented Sep 8, 2014

+1

@dizzib

This comment has been minimized.

Copy link

dizzib commented Sep 15, 2014

+1 this bug forced me to switch away from https://github.com/pluma/literalify which depends on falafel to https://github.com/thlorenz/exposify which doesn't.

@substack

This comment has been minimized.

Copy link
Owner

substack commented Feb 12, 2015

No longer a problem in 1.0.0 which just uses acorn instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment