Walking increases callstack #2

Closed
epeli opened this Issue Jun 16, 2011 · 7 comments

Comments

Projects
None yet
8 participants
@epeli

epeli commented Jun 16, 2011

If you walk enough big directory tree, node-findit will throw "RangeError: Maximum call stack size exceeded" exception.

@massimiliano-giroldi

This comment has been minimized.

Show comment Hide comment
@massimiliano-giroldi

massimiliano-giroldi Sep 29, 2011

Issue still exists.

Issue still exists.

@fahrinh

This comment has been minimized.

Show comment Hide comment
@fahrinh

fahrinh Jan 18, 2012

It happened to me too

Error raising when it reach 10220-th item

fahrinh commented Jan 18, 2012

It happened to me too

Error raising when it reach 10220-th item

@egeozcan

This comment has been minimized.

Show comment Hide comment
@egeozcan

egeozcan Apr 24, 2012

Also happens with node v0.7.8 on windows 7 64 bit and this hack applied: http://stackoverflow.com/questions/9062248/why-jasmine-node-doesnt-find-my-spec-files

Also happens with node v0.7.8 on windows 7 64 bit and this hack applied: http://stackoverflow.com/questions/9062248/why-jasmine-node-doesnt-find-my-spec-files

@mfncooper

This comment has been minimized.

Show comment Hide comment
@mfncooper

mfncooper Jun 11, 2012

This is really a showstopper. Unless you know that your tree is small, you can't risk using findit, unfortunately. It actually doesn't take that big a tree to blow it up since so much is on the stack.

This is really a showstopper. Unless you know that your tree is small, you can't risk using findit, unfortunately. It actually doesn't take that big a tree to blow it up since so much is on the stack.

@soldair

This comment has been minimized.

Show comment Hide comment
@soldair

soldair Jun 12, 2012

my package http://github.com/soldair/node-walkdir does not have this issue i would love to see if it solves your problem. npm install walkdir. it provides the same interface as findit, is faster, and the callstack doesn't keep growing.

soldair commented Jun 12, 2012

my package http://github.com/soldair/node-walkdir does not have this issue i would love to see if it solves your problem. npm install walkdir. it provides the same interface as findit, is faster, and the callstack doesn't keep growing.

@yichen

This comment has been minimized.

Show comment Hide comment
@yichen

yichen Oct 16, 2012

Just ran into this issue. Any updates?

yichen commented Oct 16, 2012

Just ran into this issue. Any updates?

@mfncooper

This comment has been minimized.

Show comment Hide comment
@mfncooper

mfncooper Oct 17, 2012

I switched to using @soldair's node-walkdir instead. Same API, and it works beautifully, even for large trees.

I switched to using @soldair's node-walkdir instead. Same API, and it works beautifully, even for large trees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment