Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native JSON and Array methods #21

Merged
merged 1 commit into from Aug 13, 2019
Merged

Use native JSON and Array methods #21

merged 1 commit into from Aug 13, 2019

Conversation

@zertosh
Copy link
Contributor

@zertosh zertosh commented Apr 13, 2016

No description provided.

@alexeyraspopov
Copy link

@alexeyraspopov alexeyraspopov commented Nov 19, 2017

@substack, do you mind merging this? Having zero dependencies is a big win.

@bryan-gislason
Copy link

@bryan-gislason bryan-gislason commented Apr 25, 2018

Bump. @substack can we merge this? the jsonify library not licensed properly. By merging this in, you'll make it easier for people to use this package without any potential legal implications.

@srghma
Copy link

@srghma srghma commented Nov 16, 2018

Since this RP is from unknown repository (arrg)
I was able to remove the dependency on jsonify doing

  1. make a clone
  2. git fetch upstream pull/21/head:without_unlicenced_jsonify
  3. push without_unlicenced_jsonify branch
  4. in package.json
  "resolutions": {
    "json-stable-stringify": "git+https://github.com/ForbesLindesay/stable-stringify.git#master",
    "shell-quote": "git+https://github.com/srghma/node-shell-quote.git#without_unlicenced_jsonify"
  },

@okdistribute
Copy link
Collaborator

@okdistribute okdistribute commented May 24, 2019

Or you could use something like license zero

@goto-bus-stop goto-bus-stop merged commit 2f97008 into substack:master Aug 13, 2019
1 check passed
@goto-bus-stop
Copy link
Collaborator

@goto-bus-stop goto-bus-stop commented Aug 13, 2019

📦 1.6.2
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants