Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows #34

Merged
merged 11 commits into from Aug 13, 2019
Merged

Support windows #34

merged 11 commits into from Aug 13, 2019

Conversation

@dy
Copy link
Contributor

@dy dy commented Jul 3, 2018

This fixes #30 and makes tests pass in windows.
Also makes possible to run glslify tests in windows.

@Karissa @jiwaddell @substack please have a look.

@okdistribute
Copy link
Collaborator

@okdistribute okdistribute commented Jul 9, 2018

Looks good, it'd be great to have travis and appveyor set up

@dy
Copy link
Contributor Author

@dy dy commented Jul 9, 2018

@okdistribute
Copy link
Collaborator

@okdistribute okdistribute commented Jul 9, 2018

@substack what do you think?

hausdorff added a commit to pulumi/pulumi-kubernetes that referenced this issue Aug 22, 2018
Fixes #143.

The nodejs library shell-quote does not escape Windows paths correctly.
An LGTM'd PR exists here[1]. Since we need it, we re-implement this for
Windows paths.

[1]: substack/node-shell-quote#34
hausdorff added a commit to pulumi/pulumi-kubernetes that referenced this issue Aug 22, 2018
Fixes #143.

The nodejs library shell-quote does not escape Windows paths correctly.
An LGTM'd PR exists here[1]. Since we need it, we re-implement this for
Windows paths.

[1]: substack/node-shell-quote#34
hausdorff added a commit to pulumi/pulumi-kubernetes that referenced this issue Aug 22, 2018
Fixes #143.

The nodejs library shell-quote does not escape Windows paths correctly.
An LGTM'd PR exists here[1]. Since we need it, we re-implement this for
Windows paths.

[1]: substack/node-shell-quote#34
hausdorff added a commit to pulumi/pulumi-kubernetes that referenced this issue Aug 22, 2018
Fixes #143.

The nodejs library shell-quote does not escape Windows paths correctly.
An LGTM'd PR exists here[1]. Since we need it, we re-implement this for
Windows paths.

[1]: substack/node-shell-quote#34
@dy
Copy link
Contributor Author

@dy dy commented Oct 20, 2018

@substack ping

Copy link
Collaborator

@goto-bus-stop goto-bus-stop left a comment

thanks! working on making CI pass on node 0.8, then will release 👍

@goto-bus-stop goto-bus-stop merged commit c5b7ca4 into substack:master Aug 13, 2019
@goto-bus-stop
Copy link
Collaborator

@goto-bus-stop goto-bus-stop commented Aug 13, 2019

📦 1.6.3

@goto-bus-stop
Copy link
Collaborator

@goto-bus-stop goto-bus-stop commented Aug 30, 2019

the path unescaping here introduced a regression. i'm reverting it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants