Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Private/Public keys does not protect anything #23

Open
vvo opened this Issue Feb 6, 2013 · 3 comments

Comments

Projects
None yet
4 participants

vvo commented Feb 6, 2013

Using example/authorized_keys, removing the part about keys in web.js:

var ports = seaport.connect(9090, require('./keys/web.json'));

to

var ports = seaport.connect(9090);

Service can still register, thus making current public/private feature, useless.

% seaport show localhost:9090
[
  {
    "id": "2CF418297F355859C4760671",
    "port": 24111,
    "role": "web",
    "version": "1.2.3",
    "host": "127.0.0.1",
    "type": "service",
    "_node": "2E0D1E487E05649A07C25859"
  }
]

I first thought I was crazy while testing on my app, then I tried your example.

Apart from this bug I must say I'm heavily using fleet and seaport. Thanks.

Contributor

nisaacson commented Jun 27, 2013

@substack Any thoughts on this? Being able to register new services while being protected via public/private keys would a really great feature

Contributor

cheddar commented Oct 15, 2013

Does #16 address this?

Contributor

nrw commented Jun 17, 2014

you can no longer register a service like this, but it does throw a really nasty error. there is some fixing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment