ports.free() for port only free implementation #12

Merged
merged 1 commit into from Oct 27, 2012

Conversation

Projects
None yet
3 participants
Contributor

DamonOehlman commented Sep 21, 2012

Putting seaport to some pretty good use at the moment, but hit an issue with a free action not working when you only specify the port. Not sure if you want to support this functionality, but it's certainly useful in our implementation and is inline with the current docs.

Additionally, I note that the current version in npm is 0.8.x but the master branch on github is sitting at 0.7.x so I guess you might be working on some changes behind the scenes.

Anyway love what you've done with the place - seaport is allowing us to implement some pretty cool decoupled services :)

Cheers,
Damon.

Contributor

mbrevoort commented Oct 21, 2012

haha - I just submitted almost the exact same pull request: #14 ... that's what I get for not looking first!

Contributor

DamonOehlman commented Oct 22, 2012

That is pretty funny, well hopefully @substack might take notice now and merge one of our requests at least...

@substack substack merged commit ef83c0b into substack:master Oct 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment